This repository was archived by the owner on Apr 1, 2026. It is now read-only.
chore: Finish factoring unit tests from presubmit#1492
Merged
TrevorBergeron merged 8 commits intomainfrom May 30, 2025
Merged
Conversation
product-auto-label
Bot
added
size: s
TrevorBergeron
force-pushed
the
unit_in_system
branch
from
c6786dd to
ce60c61
Compare
product-auto-label
Bot
added
size: xs
product-auto-label
Bot
added
size: s
tswast
reviewed
May 30, 2025
| # Sessions are executed in the order so putting the smaller sessions | ||
| # ahead to fail fast at presubmit running. | ||
| nox.options.sessions = [ | ||
| "unit", |
Contributor
There was a problem hiding this comment.
This is because it's redundant with GitHub Actions, right?
Doesn't look like
actually uses nox for the coverage step, so that's probably okay to just be system tests.
tswast
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕